PDA

View Full Version : Remove Compiler Warnings from HR-OS1 framework...



KurtEck
05-20-2015, 12:21 PM
One thing I thought I would do, was to try to eliminate all of the compiler warnings from the framework.

That way when I am making changes and so something a little off, I was pay attention to the warnings when I build...

Also while looking through PS3 code base I found some code doing nothing, which included a whole thread that was created and destroyed, which simply woke up, did nothing and then went back to sleep. So I #ifdef that code out. Not sure if the functionality that probably used to be there will return so I did not totally remove it.

I have built on both Edison and RPI2... I have found with a few changes that the system wants to say the whole file changed. Not sure if this has to do with file encodings or not.

Anyway if anyone wishes to try them out, they are up: https://github.com/KurtE/HROS1-Framework/tree/RemoveWarnings

Also it is setup that the changes can be automatically merged into main project.

Kurt

jwatte
05-20-2015, 09:06 PM
Not sure if the functionality that probably used to be there will return so I did not totally remove it.


That's what source control is for. If it's doing nothing, kill it with fire!
It's often the case that safely removing code is more valuable to long-term code health than adding new code...

DresnerRobotics
06-03-2015, 02:28 PM
Merged in, thanks KurtE!

KurtEck
06-03-2015, 04:08 PM
You are welcome. I need to get back to my HR-OS1, but having too much fun playing with PhantomX stuff

DresnerRobotics
06-03-2015, 04:11 PM
You are welcome. I need to get back to my HR-OS1, but having too much fun playing with PhantomX stuff

I think you of all people will really appreciate our upcoming MK III release. :)

KurtEck
06-03-2015, 09:44 PM
I think you of all people will really appreciate our upcoming MK III release. :)
Sounds Intriguing ;)